Repository navigation
test(coverage): Batch 1 — RadioGroup, Tabs, factoryResetService #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /** | ||
| * Tests for components/ui/RadioGroup.tsx | ||
| * QNBS-v3: Accessible radiogroup atom — render, checked state, onChange, disabled, description, orientation. | ||
| */ | ||
| import { render, screen } from '@testing-library/react'; | ||
| import userEvent from '@testing-library/user-event'; | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
| import { RadioGroup } from '../../components/ui/RadioGroup'; | ||
|
|
||
| const OPTIONS = [ | ||
| { value: 'a', label: 'Option A', description: 'First choice' }, | ||
| { value: 'b', label: 'Option B' }, | ||
| { value: 'c', label: 'Option C', disabled: true }, | ||
| ]; | ||
|
|
||
| describe('RadioGroup', () => { | ||
| it('renders a radiogroup with each option label and description', () => { | ||
| render(<RadioGroup options={OPTIONS} value="a" onChange={vi.fn()} name="choices" />); | ||
| expect(screen.getByRole('radiogroup', { name: 'choices' })).toBeInTheDocument(); | ||
| expect(screen.getByRole('radio', { name: 'Option A' })).toBeInTheDocument(); | ||
| expect(screen.getByRole('radio', { name: 'Option B' })).toBeInTheDocument(); | ||
| expect(screen.getByText('First choice')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('marks the option matching value as checked', () => { | ||
| render(<RadioGroup options={OPTIONS} value="b" onChange={vi.fn()} name="choices" />); | ||
| expect(screen.getByRole('radio', { name: 'Option B' })).toBeChecked(); | ||
| expect(screen.getByRole('radio', { name: 'Option A' })).not.toBeChecked(); | ||
| }); | ||
|
|
||
| it('calls onChange with the option value when an option is selected', async () => { | ||
| const user = userEvent.setup(); | ||
| const onChange = vi.fn(); | ||
| render(<RadioGroup options={OPTIONS} value="a" onChange={onChange} name="choices" />); | ||
| await user.click(screen.getByRole('radio', { name: 'Option B' })); | ||
| expect(onChange).toHaveBeenCalledWith('b'); | ||
| }); | ||
|
|
||
| it('renders disabled options as disabled and does not fire onChange', async () => { | ||
| const user = userEvent.setup(); | ||
| const onChange = vi.fn(); | ||
| render(<RadioGroup options={OPTIONS} value="a" onChange={onChange} name="choices" />); | ||
| const disabled = screen.getByRole('radio', { name: 'Option C' }); | ||
| expect(disabled).toBeDisabled(); | ||
| await user.click(disabled); | ||
| expect(onChange).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('applies horizontal orientation layout', () => { | ||
| render( | ||
| <RadioGroup | ||
| options={OPTIONS} | ||
| value="a" | ||
| onChange={vi.fn()} | ||
| name="choices" | ||
| orientation="horizontal" | ||
| />, | ||
| ); | ||
| expect(screen.getByRole('radiogroup').className).toContain('flex-row'); | ||
| }); | ||
|
|
||
| it('defaults to vertical orientation', () => { | ||
| render(<RadioGroup options={OPTIONS} value="a" onChange={vi.fn()} name="choices" />); | ||
| expect(screen.getByRole('radiogroup').className).toContain('flex-col'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /** | ||
| * Tests for components/ui/Tabs.tsx (Tabs + TabPanel) | ||
| * QNBS-v3: WAI-ARIA tabs atom — tablist/tab roles, aria-selected, onChange, disabled, variants, panel visibility. | ||
| */ | ||
| import { render, screen } from '@testing-library/react'; | ||
| import userEvent from '@testing-library/user-event'; | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
| import { TabPanel, Tabs } from '../../components/ui/Tabs'; | ||
|
|
||
| const TABS = [ | ||
| { id: 'one', label: 'One' }, | ||
| { id: 'two', label: 'Two' }, | ||
| { id: 'three', label: 'Three', disabled: true }, | ||
| ]; | ||
|
|
||
| describe('Tabs', () => { | ||
| it('renders a tablist with a tab per entry', () => { | ||
| render(<Tabs tabs={TABS} activeTab="one" onChange={vi.fn()} ariaLabel="Sections" />); | ||
| expect(screen.getByRole('tablist', { name: 'Sections' })).toBeInTheDocument(); | ||
| expect(screen.getAllByRole('tab')).toHaveLength(3); | ||
| }); | ||
|
|
||
| it('marks the active tab with aria-selected', () => { | ||
| render(<Tabs tabs={TABS} activeTab="two" onChange={vi.fn()} ariaLabel="Sections" />); | ||
| expect(screen.getByRole('tab', { name: 'Two' })).toHaveAttribute('aria-selected', 'true'); | ||
| expect(screen.getByRole('tab', { name: 'One' })).toHaveAttribute('aria-selected', 'false'); | ||
| }); | ||
|
|
||
| it('calls onChange with the tab id when a tab is clicked', async () => { | ||
| const user = userEvent.setup(); | ||
| const onChange = vi.fn(); | ||
| render(<Tabs tabs={TABS} activeTab="one" onChange={onChange} ariaLabel="Sections" />); | ||
| await user.click(screen.getByRole('tab', { name: 'Two' })); | ||
| expect(onChange).toHaveBeenCalledWith('two'); | ||
| }); | ||
|
|
||
| it('does not fire onChange for a disabled tab', async () => { | ||
| const user = userEvent.setup(); | ||
| const onChange = vi.fn(); | ||
| render(<Tabs tabs={TABS} activeTab="one" onChange={onChange} ariaLabel="Sections" />); | ||
| const disabled = screen.getByRole('tab', { name: 'Three' }); | ||
| expect(disabled).toBeDisabled(); | ||
| await user.click(disabled); | ||
| expect(onChange).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('applies the pills variant class on tabs', () => { | ||
| render(<Tabs tabs={TABS} activeTab="one" onChange={vi.fn()} ariaLabel="S" variant="pills" />); | ||
| expect(screen.getByRole('tab', { name: 'One' }).className).toContain('rounded-full'); | ||
| }); | ||
|
|
||
| it('marks the active tab with data-state=active and inactive otherwise', () => { | ||
| render( | ||
| <Tabs tabs={TABS} activeTab="one" onChange={vi.fn()} ariaLabel="S" variant="underline" />, | ||
| ); | ||
| expect(screen.getByRole('tab', { name: 'One' })).toHaveAttribute('data-state', 'active'); | ||
| expect(screen.getByRole('tab', { name: 'Two' })).toHaveAttribute('data-state', 'inactive'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('TabPanel', () => { | ||
| it('shows content and exposes the tabpanel role when active', () => { | ||
| render( | ||
| <TabPanel tabId="one" activeTab="one" groupId="grp"> | ||
| Panel One | ||
| </TabPanel>, | ||
| ); | ||
| const panel = screen.getByRole('tabpanel'); | ||
| expect(panel).not.toHaveAttribute('hidden'); | ||
| expect(panel).toHaveTextContent('Panel One'); | ||
| expect(panel).toHaveAttribute('aria-labelledby', 'grp-one'); | ||
| expect(panel).toHaveAttribute('id', 'grp-one-panel'); | ||
| }); | ||
|
|
||
| it('hides the panel when not the active tab', () => { | ||
| render( | ||
| <TabPanel tabId="one" activeTab="two" groupId="grp"> | ||
| Panel One | ||
| </TabPanel>, | ||
| ); | ||
| // A hidden tabpanel is removed from the a11y tree, so query the section directly. | ||
| const section = screen.getByText('Panel One').closest('section'); | ||
| expect(section).toHaveAttribute('hidden'); | ||
| expect(section?.className).toContain('hidden'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| /** | ||
| * Tests for services/factoryResetService.ts | ||
| * QNBS-v3: wipeAllAppData — clears IDB + web storage + SW caches, then reloads. Covers the | ||
| * native indexedDB.databases() path, the known-list fallback, and the Cache API branch. | ||
| */ | ||
| import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'; | ||
| import { wipeAllAppData } from '../../services/factoryResetService'; | ||
| import { logger } from '../../services/logger'; | ||
|
|
||
| vi.mock('../../services/logger', () => ({ | ||
| logger: { warn: vi.fn(), info: vi.fn(), error: vi.fn() }, | ||
| })); | ||
|
|
||
| function createDb(name: string): Promise<void> { | ||
| return new Promise((resolve, reject) => { | ||
| const req = indexedDB.open(name, 1); | ||
| req.onupgradeneeded = () => req.result.createObjectStore('s'); | ||
| req.onsuccess = () => { | ||
| req.result.close(); | ||
| resolve(); | ||
| }; | ||
| req.onerror = () => reject(req.error); | ||
| }); | ||
| } | ||
|
|
||
| let reloadMock: ReturnType<typeof vi.fn>; | ||
| let originalLocation: Location; | ||
|
|
||
| beforeEach(() => { | ||
| vi.clearAllMocks(); | ||
| reloadMock = vi.fn(); | ||
| originalLocation = window.location; | ||
| Object.defineProperty(window, 'location', { | ||
| configurable: true, | ||
| value: { ...originalLocation, reload: reloadMock }, | ||
| }); | ||
| localStorage.clear(); | ||
| sessionStorage.clear(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| Object.defineProperty(window, 'location', { configurable: true, value: originalLocation }); | ||
| vi.unstubAllGlobals(); | ||
| }); | ||
|
|
||
| describe('wipeAllAppData', () => { | ||
| it('clears web storage, deletes IDB databases, and reloads', async () => { | ||
| await createDb('storycraft-data-db'); | ||
| localStorage.setItem('foo', 'bar'); | ||
| sessionStorage.setItem('baz', 'qux'); | ||
| const delSpy = vi.spyOn(indexedDB, 'deleteDatabase'); | ||
|
|
||
| await wipeAllAppData(); | ||
|
|
||
| expect(localStorage.getItem('foo')).toBeNull(); | ||
| expect(sessionStorage.getItem('baz')).toBeNull(); | ||
| expect(delSpy).toHaveBeenCalledWith('storycraft-data-db'); | ||
| expect(reloadMock).toHaveBeenCalledTimes(1); | ||
| expect(logger.warn).toHaveBeenCalledTimes(1); | ||
| delSpy.mockRestore(); | ||
| }); | ||
|
|
||
| it('falls back to the known database list when indexedDB.databases() fails', async () => { | ||
| const dbSpy = vi.spyOn(indexedDB, 'databases').mockRejectedValueOnce(new Error('not allowed')); | ||
| const delSpy = vi.spyOn(indexedDB, 'deleteDatabase'); | ||
|
|
||
| await wipeAllAppData(); | ||
|
|
||
| // Fallback deletes every name in the known list (e.g. the logs DB). | ||
| expect(delSpy).toHaveBeenCalledWith('storycraft-logs-db'); | ||
| expect(reloadMock).toHaveBeenCalledTimes(1); | ||
| dbSpy.mockRestore(); | ||
| delSpy.mockRestore(); | ||
| }); | ||
|
|
||
| it('clears service-worker caches when the Cache API is available', async () => { | ||
| const del = vi.fn().mockResolvedValue(true); | ||
| vi.stubGlobal('caches', { | ||
| keys: vi.fn().mockResolvedValue(['static-v1', 'dynamic-v1']), | ||
| delete: del, | ||
| }); | ||
|
|
||
| await wipeAllAppData(); | ||
|
|
||
| expect(del).toHaveBeenCalledWith('static-v1'); | ||
| expect(del).toHaveBeenCalledWith('dynamic-v1'); | ||
| expect(reloadMock).toHaveBeenCalledTimes(1); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.