Clippy update #116
Merged
Clippy update #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
qmonnet
commented
Oct 29, 2024
qmonnet
commented
- src: Fix deprecated calls to 'feature = "cargo-clippy"'
- src: Fix Clippy reports
- ci: Add features to clippy pass
- src: Remove presumably unused Clippy directives
qmonnet
force-pushed
the
pr/clippy-update
branch
from
4e47ebf to
fdf6cfe
Compare
Get rid of the deprecated attribute and simplify the lint indications. Link: https://blog.rust-lang.org/2024/02/28/Clippy-deprecating-feature-cargo-clippy.html Signed-off-by: Quentin Monnet <[email protected]>
Some of these reports were fixed automatically with:
cargo +nightly clippy --fix --lib -p rbpf
Signed-off-by: Quentin Monnet <[email protected]>
Apply the linter for different combinations of features (and not only combinations of toolchains). Signed-off-by: Quentin Monnet <[email protected]>
"cargo clippy" seems to pass just fine without most of the Clippy directives we have in the code. I believe some issues have been fixed over time, some directives were unnecessarily added when copy-pasting into a new file, and for the rest I'm not sure; likely, Clippy's behaviour has changed somewhat over time. Anyway, let's remove these if they are not necessary. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/clippy-update
branch
from
fdf6cfe to
07056ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.