Reduce usage of libc #114
Merged
Reduce usage of libc #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am attempting to reduce the dependence on libc in my indirect dependencies. While looking at this crate I noticed some low-hanging fruit that can be very easily replaced with libc. - The rand() function can be re-implemented as a simple Wyrand seeded by the thread ID and the current time. - libc::memcpy is used at a point where it can be replaced with ptr::copy_nonoverlapping. - libc is used for memory allocation at a point where std::alloc can be used instead. So I use this. I'm not too familiar with this codebase, so if any of these replacements are incorrect, please let me know. The only leftover libc call is mprotect(). Signed-off-by: John Nunley <[email protected]>
qmonnet
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am attempting to reduce the dependence on libc in my indirect
dependencies. While looking at this crate I noticed some low-hanging
fruit that can be very easily replaced with libc.
the thread ID and the current time.
ptr::copy_nonoverlapping.
used instead. So I use this.
I'm not too familiar with this codebase, so if any of these replacements
are incorrect, please let me know.
The only leftover libc call is mprotect().