Update two sentences in intro.md #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first edit adds "for" in front of each enumeration following "designed" because they are so different that the "for" helps make them consistent and clarifies that they are enumerations. The very first "for" is sandwiched between the verb-adverb "designed from the ground up" and "creating"... it could modify either one. "for creating [...], for speed, and for easier reading" is easier to understand than "for creating[...], speed, and easier reading" if the reader mistakenly associates "for" with "creating" instead of "designing". There are other ways to simplify the sentence, but this keeps the original intent IMO. The second edit is more obvious: "For example, place me" doesn't fit with the writing style. Just below there is "For example, to nudge" so I modeled the change for the "place me" sentence after the "to nudge" sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first edit adds "for" in front of each enumeration following "designed" because they are so different that the "for" helps make them consistent and clarifies that they are enumerations. The very first "for" is sandwiched between the verb-adverb "designed from the ground up" and "creating"... it could modify either one. "for creating [...], for speed, and for easier reading" is easier to understand than "for creating[...], speed, and easier reading" if the reader mistakenly associates "for" with "creating" instead of "designing". There are other ways to simplify the sentence, but this keeps the original intent IMO.
The second edit is more obvious: "For example, place me" doesn't fit with the writing style. Just below there is "For example, to nudge" so I modeled the change for the "place me" sentence after the "to nudge" sentence.