Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple shell.nix to enable QMK toolchain in shell #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a simple shell.nix to enable QMK toolchain in shell #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .envrc
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not everyone wants to use nix; this file should be removed. Feel free to add instructions in a comment in the shell.nix file, or some sort of associated readme that explains the setup procedure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nor does everybody run around with direnv — if I’d made that assumption we’d already have one with layout python3 so that we don’t have issues with system packages.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
use nix
10 changes: 10 additions & 0 deletions shell.nix
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d prefer this go into a util/nix directory and instructions provided on how to enable it. Remember people have full control over their userspace repo; they can commit those to their fork after placing things in the right spot.

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
let
nixpkgs = fetchTarball "https://github.com/NixOS/nixpkgs/tarball/nixos-24.05";
pkgs = import nixpkgs { config = {}; overlays = []; };
in

pkgs.mkShellNoCC {
packages = with pkgs; [
qmk
];
}