Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix positioning for key tester and HID console windows #465

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

fauxpark
Copy link
Member

Description

FormStartPosition.CenterParent doesn't work unless you show the window with ShowDialog(). Since we still want to allow interaction with the main window while they are open we have to use Show() instead and manually call CenterToParent() in the Load event handler.

And as usual Visual Studio wanted to move things around in the Designer.cs and resx files...

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team March 20, 2024 05:22
@fauxpark
Copy link
Member Author

The designer changes seem to be mostly reducing verbosity (eg. removing pointless this, parentheses and casts etc). There should be no actual UI changes.

@tzarc
Copy link
Member

tzarc commented Mar 20, 2024

The designer changes seem to be mostly reducing verbosity (eg. removing pointless this, parentheses and casts etc). There should be no actual UI changes.

It's a codegen'ed file, so it should be fine to basically ignore so long as it "looks close enough".

Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler to review without whitespace. LGTM.

@fauxpark fauxpark merged commit 370f0dc into qmk:master Mar 22, 2024
5 checks passed
@fauxpark fauxpark deleted the child-windows-centering branch March 22, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants