Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up bootloader detection on M1 Macs. #350

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Fix up bootloader detection on M1 Macs. #350

merged 2 commits into from
Apr 22, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Apr 22, 2022

Description

The wrong device class name was being sent back on M1 Macs, breaking detection.
This PR allows for either/or.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

@tzarc tzarc requested review from fauxpark and a team April 22, 2022 03:29
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
https://developer.apple.com/documentation/kernel/iousbdevice
Perhaps IOUSBDevice can be replaced entirely?

Nope.

macos/QMK Toolbox/USB/USBListener.m Outdated Show resolved Hide resolved
macos/QMK Toolbox/USB/USBListener.m Outdated Show resolved Hide resolved
@tzarc tzarc requested a review from fauxpark April 22, 2022 07:44
@fauxpark fauxpark merged commit 31b52c8 into master Apr 22, 2022
@fauxpark fauxpark deleted the fixup-m1 branch April 22, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants