Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default keymap download section #314

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Remove default keymap download section #314

merged 2 commits into from
Oct 29, 2021

Conversation

fauxpark
Copy link
Member

Description

Just removing stuff for now, UI rearrangements will come later.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark merged commit 742b148 into qmk:master Oct 29, 2021
@fauxpark fauxpark deleted the remove-default-keymap-download-section branch October 29, 2021 04:35
@Producdevity
Copy link

Am I missing something or is this functionality now completely missing (the search bar)?

@fauxpark
Copy link
Member Author

See the above linked PR.

@Producdevity
Copy link

Could you please guide me to the reasoning? I don’t understand the removal of the search bar. The only things I reasons I can find are related to code quality, which shouldn’t have any influence on decisions like this imo. Maybe I missed something, please let me know if I did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify local file/qmk.fm UI
3 participants