Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Subclass ComboBox for placeholder text #277

Merged
merged 2 commits into from
Jul 15, 2021
Merged

[Windows] Subclass ComboBox for placeholder text #277

merged 2 commits into from
Jul 15, 2021

Conversation

fauxpark
Copy link
Member

Description

Hiding away the ugly SendMessage() in a subclass that can be reused for both boxes, because WinForms is dumb and doesn't come OOB with a placeholder text property...

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team July 10, 2021 10:39
@fauxpark fauxpark requested a review from a team July 12, 2021 04:33
@fauxpark
Copy link
Member Author

Updated with more robust implementation from https://stackoverflow.com/a/8744360

@fauxpark fauxpark merged commit 36d8260 into qmk:master Jul 15, 2021
@fauxpark fauxpark deleted the placeholder-combo-box branch July 15, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants