[Keymap] Improvements to KidBrazil keymap to better handle OLED/LED Matrix timeout. #7688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Custom Font -Custom OLED output
* Setup Oled timeout based on simple timer * Cleaned up comments and added timeout for LEDs * Fixed some small errors * Updated oled timout with matrix scan * Updated oled timout with matrix scan * Update withou eeprom * Update timer code * Use process user instead of keymap * Added ifdef to protect oledtimer * Updated with half timeout state for logo * Removed middle tier timer
- Added boolean to hold LED state - Added init function to set rgb to known state - Modified RGB_TOG to work with noeeprom commands
kidBrazil
force-pushed
the
kidbrazil/oled-timeout-improvements
branch
from
16b5997
to
19e7051
Compare
noroadsleft
requested changes
Jan 3, 2020
drashna
approved these changes
Jan 5, 2020
Co-Authored-By: James Young <[email protected]>
|
@noroadsleft I commited your suggestion via the browser, not sure it took yet. Cant seem to see it on the diff so I will fix it manually and request a review again. Cheers |
kidBrazil
commented
Jan 7, 2020
| user has disabled it via RGB_TOG. | ||
|
|
||
| ## Flashing | ||
| To flash this on your CRKBD simply use the `make crkbd:kidbrazil:flash` |
There was a problem hiding this comment.
Looks like it worked!
noroadsleft
approved these changes
Jan 8, 2020
|
Thanks! |
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
…atrix timeout. (qmk#7688) * Added KidBrazil custom keymap for CRKBD -Custom Font -Custom OLED output * Added missing readme * Oled Timeout Update for KidBrazil Keymap (qmk#1) * Setup Oled timeout based on simple timer * Cleaned up comments and added timeout for LEDs * Fixed some small errors * Updated oled timout with matrix scan * Updated oled timout with matrix scan * Update withou eeprom * Update timer code * Use process user instead of keymap * Added ifdef to protect oledtimer * Updated with half timeout state for logo * Removed middle tier timer * Final cleanup of unused files * Updated code as per suggestions & requests * Second round of revisions * Updated keymap to better handle LED timeout - Added boolean to hold LED state - Added init function to set rgb to known state - Modified RGB_TOG to work with noeeprom commands * Finished adding the timeout for OLED and testing on CRKBD * Updated documentation * fixed the timeout logic so it works as intended * Update keyboards/crkbd/keymaps/kidbrazil/README.md
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
…atrix timeout. (qmk#7688) * Added KidBrazil custom keymap for CRKBD -Custom Font -Custom OLED output * Added missing readme * Oled Timeout Update for KidBrazil Keymap (qmk#1) * Setup Oled timeout based on simple timer * Cleaned up comments and added timeout for LEDs * Fixed some small errors * Updated oled timout with matrix scan * Updated oled timout with matrix scan * Update withou eeprom * Update timer code * Use process user instead of keymap * Added ifdef to protect oledtimer * Updated with half timeout state for logo * Removed middle tier timer * Final cleanup of unused files * Updated code as per suggestions & requests * Second round of revisions * Updated keymap to better handle LED timeout - Added boolean to hold LED state - Added init function to set rgb to known state - Modified RGB_TOG to work with noeeprom commands * Finished adding the timeout for OLED and testing on CRKBD * Updated documentation * fixed the timeout logic so it works as intended * Update keyboards/crkbd/keymaps/kidbrazil/README.md
markstos
reviewed
Aug 27, 2020
| if (record->event.pressed) { | ||
| #ifdef OLED_DRIVER_ENABLE | ||
| oled_timer = timer_read32(); | ||
| #endif |
There was a problem hiding this comment.
There is a logic bug here. Although the variable is named oled_timer, it's used to timeout both the RGB Matrix and the OLEDs. As it's written, disabling the OLEDs will break the RGB Matrix timeout because oled_timer will not be set.
To resolve it, I recommend renaming oled_timer to timeout_timer and remove the conditional ifdef here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to improve the behaviour of the OLED and LED Matrix timeouts introduced in the original PR for this keymap. With this PR the user will actually be able to toggle the RGB matrix on/off and have it stay that way when the keyboard wakes up.
Apparently rgbmatrix info is not readily available to pull from the eeprom so my approach was to initialize the keyboard to a known state and use some volatile booleans to store the current state while the keyboard is powered up.
Types of Changes
Checklist