Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip definitions of macOS brightness alias #4868

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Flip definitions of macOS brightness alias #4868

merged 1 commit into from
Jan 18, 2019

Conversation

juno
Copy link
Contributor

@juno juno commented Jan 18, 2019 •
edited
Loading

Description

The brightness aliases for macOS (KC_BRMU and KC_BRMD) seems to be mistakenly flipped.

in docs/keycodes.md:

Key Aliases Description
KC_SCROLLLOCK KC_SLCK, KC_BRMD Scroll Lock, Brightness Down (macOS)
KC_PAUSE KC_PAUS, KC_BRK, KC_BRMU Pause, Brightness Up (macOS)

in tmk_core/common/keycode.h:

#define KC_BRMU KC_SCROLLLOCK
#define KC_BRMD KC_PAUSE

These aliases introduced in #4836.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Flip definitions of macOS brightness alias
70ffd33 
Before:
KC_BRMU - Brightness Down
KC_BRMD - Brightness Up

After:
KC_BRMU - Brightness Up
KC_BRMD - Brightness Down
@drashna
Copy link
Member

drashna commented Jan 18, 2019

Nice catch. thanks!

@drashna drashna merged commit 1d0bc5b into qmk:master Jan 18, 2019
@juno juno deleted the fix-macos-brightness-aliases branch January 18, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juno @drashna