Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

40percent.club Luddite: Configurator update #4859

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

noroadsleft
Copy link
Member

Description

Was looking into some Configurator stuff and saw that the keyboard_name value was wrong, so fixed that.

Also reformatted the file so each key's object has its own line. I've started doing this because I've found it makes info.json files easier to debug when chasing down errors.

Commit Log

40percent.club Luddite: Configurator update (d0cf386)

  • corrected value for keyboard_name
  • reformatted file

- corrected value for keyboard_name
- reformatted file
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@mechmerlin mechmerlin merged commit e48cb34 into qmk:master Jan 16, 2019
@noroadsleft noroadsleft deleted the cf/40pct_luddite branch January 16, 2019 22:06
akrob pushed a commit to akrob/qmk_firmware that referenced this pull request Jan 19, 2019
* upstream/master: (390 commits)
  [Keyboard] handwired/ortho60 Configurator update, readme update, and rules tidy (qmk#4877)
  Fix Encoder documentation (qmk#4861)
  TKC1800 refactor and Configurator visual fixes (qmk#4870)
  Fixed the build break of helix/rev1:OLED_sample caused by PR qmk#4462. (qmk#4874)
  Add cursor keys to top layer (qmk#4876)
  [Keyboard] Fix bootloader size for v60_type_r (qmk#4873)
  Flip definitions of macOS brightness alias
  Grammatical fixes for GPIO Control doc (qmk#4869)
  handwired/ortho5x13: layout macro refactor
  Add new brightness aliases to keycodes_basic.md
  [Keyboard] update VENDOR_ID, PRODUCT_ID, and DEVICE_VER for Duck boards (qmk#4612)
  Add Planck rev1 and rev2, clean up rev3-5 config.h
  Allows Terminal to use ModTap/LayerTap keys (qmk#4586)
  Defined IS_(HOST_)LED_ON/OFF() and improved LED documentation (qmk#4853)
  MacOS Brightness Alias (qmk#4836)
  [Keymap] added custom led effect keymap.c (qmk#4856)
  Simplify split_common Code significantly (qmk#4772)
  Add documentation and fix formating (qmk#4860)
  [Keymap] Adding bdk keymap for ergobox_ez (qmk#4850)
  40percent.club Luddite: Configurator update (qmk#4859)
  ...
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
- corrected value for keyboard_name
- reformatted file
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
- corrected value for keyboard_name
- reformatted file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants