Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Caps key led for dz60. #4724

Merged
merged 1 commit into from
Dec 29, 2018
Merged

Fix Caps key led for dz60. #4724

merged 1 commit into from
Dec 29, 2018

Conversation

Menchen
Copy link
Contributor

@Menchen Menchen commented Dec 25, 2018

Description

As the state of dz60.c in this repo right now, the caps key led isn't working. This fix caps led for dz60 tested on multiple OS(Linux, macOS, and windows).

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

This is my first pr, so please correct me if I have done something wrong.

@mechmerlin
Copy link
Contributor

Can someone with a DZ60 and a soldered in LED test this?

@Menchen
Copy link
Contributor Author

Menchen commented Dec 26, 2018

Can someone with a DZ60 and a soldered in LED test this?

Well, I tested it with my dz60, but if you need more confirm I think this reddit post can help, the second code posted by @drashna is the correct one(all I did was porting it from keymap.c to dz60.c ).

@mechmerlin
Copy link
Contributor

Oh yeah, I just wanted someone other than the dev who submitted it to test. Cuz I have no way of testing this other than by looking at the code and say, "oh yes that works".

@fauxpark
Copy link
Member

If I'm reading this correctly, setting B2 to output low turns the LED on?

@Menchen
Copy link
Contributor Author

Menchen commented Dec 27, 2018

If I'm reading this correctly, setting B2 to output low turns the LED on?

Yeah, it's a bit weird, mine dz60 was a prebuild one from kbcfans and this pr work as expected, you can also see at the reddit post that I linked link above to see that. Not sure why.

@skullydazed skullydazed merged commit e2f60eb into qmk:master Dec 29, 2018
@skullydazed
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants