Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some optimization to the Tetris keyboard #4645

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Add some optimization to the Tetris keyboard #4645

merged 1 commit into from
Dec 14, 2018

Conversation

drashna
Copy link
Member

@drashna drashna commented Dec 14, 2018 •
edited
Loading

Description

Reduce the file size and optimize the Tetris keyboard.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mechmerlin
mechmerlin approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@mechmerlin mechmerlin merged commit 161ffa0 into qmk:master Dec 14, 2018
@drashna drashna deleted the fix/tetris_size_issues branch December 14, 2018 18:46
ishtob pushed a commit to ishtob/qmk_firmware that referenced this pull request Jan 1, 2019
@drashna @ishtob
Add some optimization to the Tetris keyboard (qmk#4645)
6a6cb1c
yeliu84 pushed a commit to yeliu84/qmk_firmware that referenced this pull request Jan 7, 2019
@drashna @yeliu84
Add some optimization to the Tetris keyboard (qmk#4645)
e3a018b
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
@drashna @rseymour
Add some optimization to the Tetris keyboard (qmk#4645)
43e5bfa
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
@drashna @djthread
Add some optimization to the Tetris keyboard (qmk#4645)
9aa62a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin approved these changes

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@ezuk ezuk Awaiting requested review from ezuk

@skullydazed skullydazed Awaiting requested review from skullydazed

@fredizzimo fredizzimo Awaiting requested review from fredizzimo

Assignees
No one assigned
Labels
keyboard optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @mechmerlin