-
-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the correct path to the split keyboard EEPROM files #4585
Conversation
Travis CI error is unrelated. |
Travis CI error is explicitly due to an issue with the avr-gcc compiler that it uses. I'm using the same version on both MSYS and ubuntu and it compiles under size....
Yes, I think it should, honestly.
For keymap readme's, no. Just the main readme for the keyboard (and maybe the default keymap's readme".
I'd say only if these keyboards have been converted and tested with the split common code. For now, it should be fine. |
@drashna Thanks, i will make those updates shortly. @bbaserdem Now that the Lets Split uses the split keyboard common code, there are stale reference to the eeprom files within |
Awesome, thanks! |
* Document the correct path to the split keyboard EEPROM files * Document the correct path to the split keyboard EEPROM files
* Document the correct path to the split keyboard EEPROM files * Document the correct path to the split keyboard EEPROM files
* Document the correct path to the split keyboard EEPROM files * Document the correct path to the split keyboard EEPROM files
* Document the correct path to the split keyboard EEPROM files * Document the correct path to the split keyboard EEPROM files
Description
This fixes incorrect paths to the split keyboard EEPROM files within the repo.
Other items for potential review:
./quantum/split_common/eeprom-lefthand.eep
and./quantum/split_common/eeprom-righthand.eep
?Should this PR update the location withinNot required./keyboards/lets_split/keymaps/bbaserdem/README.md
?Should this PR remove the other eeprom files withinNot requiredminidox
anddeltasplit75
so that the only eeprom files are within the common folder?Types of changes
Checklist: