Refactor fourier to use split common code #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to make sure, you've tested this on a fourier, both serial and i2c, and it works fine? |
|
@drashna Currently I've only managed to test a serial setup (as all my i2c other boards have some weird issues with left side only underglow when doing layer indication). Happy to mark this as WIP till someone else can help test? However none of the current keymaps use I2C so i cannot tag anyone for help. |
|
@nooges This look okay? Also, if you have an i2c board to test? |
|
Will test in the next couple days once I get to my Fourier test board |
drashna
requested changes
Dec 14, 2018
zvecr
force-pushed
the
feature/fourier-SPLIT_KEYBOARD
branch
from
5542250
to
b3c462f
Compare
|
And with the recent master changes, we should be good for testing again. |
|
Confirmed to work with I2C on my Fourier |
|
Awesome, thanks @nooges |
drashna
approved these changes
Dec 14, 2018
|
Awesome, thanks! |
ishtob
pushed a commit
to ishtob/qmk_firmware
that referenced
this pull request
Jan 1, 2019
* Refactor fourier to use split common code * Refactor fourier to use split common code - fix handedness when not using EE_HANDS or MASTER_LEFT * add SOFT_SERIAL_PIN config
yeliu84
pushed a commit
to yeliu84/qmk_firmware
that referenced
this pull request
Jan 7, 2019
* Refactor fourier to use split common code * Refactor fourier to use split common code - fix handedness when not using EE_HANDS or MASTER_LEFT * add SOFT_SERIAL_PIN config
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
* Refactor fourier to use split common code * Refactor fourier to use split common code - fix handedness when not using EE_HANDS or MASTER_LEFT * add SOFT_SERIAL_PIN config
djthread
pushed a commit
to djthread/qmk_firmware
that referenced
this pull request
Mar 17, 2019
* Refactor fourier to use split common code * Refactor fourier to use split common code - fix handedness when not using EE_HANDS or MASTER_LEFT * add SOFT_SERIAL_PIN config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've followed what has been done previously to other boards (#3639).
A quick diff of the common split files and this keyboards copy seems like the differences are minimal and mostly in the area of backlight/rgb, but let me know if anything else is required.
Types of changes
Checklist: