Lets split eh default keymap - Fixes for superseded default layer functionality #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump Is there anything else required to progress this? |
|
Nope, just a friendly reminder was needed. :) |
|
Thanks @drashna for the quick response. |
ishtob
pushed a commit
to ishtob/qmk_firmware
that referenced
this pull request
Jan 1, 2019
… layer functionality (qmk#4581) * Fixes for superseded default layer functionality * Fixes for superseded default layer functionality
yeliu84
pushed a commit
to yeliu84/qmk_firmware
that referenced
this pull request
Jan 7, 2019
… layer functionality (qmk#4581) * Fixes for superseded default layer functionality * Fixes for superseded default layer functionality
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
… layer functionality (qmk#4581) * Fixes for superseded default layer functionality * Fixes for superseded default layer functionality
djthread
pushed a commit
to djthread/qmk_firmware
that referenced
this pull request
Mar 17, 2019
… layer functionality (qmk#4581) * Fixes for superseded default layer functionality * Fixes for superseded default layer functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the recent nori port, part of the review highlighted that the keymap contained some legacy code.
Apply the review changes a92b03d to the Lets split eh default keymap.
Types of changes
Checklist: