Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ergodox_ez: Fix the PORTD bit set when row == 11 #4464

Closed
wants to merge 1 commit into from
Closed

ergodox_ez: Fix the PORTD bit set when row == 11 #4464

wants to merge 1 commit into from

Commits on Nov 22, 2018

  1. ergodox_ez: Fix the PORTD bit set when row == 11 

    In the `select_row` implementation of the ErgoDox EZ, when row == 11, the code
was changing the 3rd bit of PORTD instead of the 2nd (DDRD was done correctly).

For some odd reason, the keyboard works either way, but it's better to be doing
things correctly and not relying on chance.

Signed-off-by: Gergely Nagy <[email protected]>
    @algernon
    algernon committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    70b7204 View commit details
    Browse the repository at this point in the history