Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve new_project script #4373

Merged
merged 4 commits into from
Nov 12, 2018
Merged

Improve new_project script #4373

merged 4 commits into from
Nov 12, 2018

Commits on Nov 6, 2018

  1. Improve new_project script 

     - use git user.name if available to replace the boilerplate name in
   files we generate
 - fix shellshock warnings
    @yanfali
    yanfali committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    f89cada View commit details
    Browse the repository at this point in the history

  2. Test for git repo 

    Suggestion by @skullydazed
    @yanfali
    yanfali committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    ac491e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. Fix shellshock warning

    @yanfali
    yanfali committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    937a304 View commit details
    Browse the repository at this point in the history

  2. Incorporate feedback from reviewers 

     - thanks @vomindoraan
 - use a heredoc instead of echo for console
 - factor out common paths
    @yanfali
    yanfali committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    f229c71 View commit details
    Browse the repository at this point in the history