Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial foobar port #4367

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Initial foobar port #4367

merged 1 commit into from
Nov 6, 2018

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 6, 2018

Port of original TMK firmware (https://github.com/di0ib/tmk_keyboard/tree/master/keyboard/foobar) following what has been previously done for other 40percent.club boards.

@drashna
Copy link
Member

drashna commented Nov 6, 2018

Could you be willing to move this into a subfolder? Eg /keyboards/40percentclub/foobar

Since there are a number of 40percent club boards, it would make sense here.

@zvecr
Copy link
Member Author

zvecr commented Nov 6, 2018

Happy to, however i have another pull request open #4355.

Would it be best to move all 40percent club boards (gherkin,tomato,4x4,5x5) as a bulk move afterwards?

@drashna
Copy link
Member

drashna commented Nov 6, 2018

If you're willing to open another PR to bulk move them, then that should be fine.

@drashna drashna merged commit a3bb8c0 into qmk:master Nov 6, 2018
@zvecr zvecr deleted the feature/port-foobar branch November 7, 2018 00:00
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Nov 17, 2018
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants