Improve wording, punctuation and capitalization in newbs_getting_started guide #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vomindoraan
force-pushed
the
newbs_getting_started_wording
branch
6 times, most recently
from
0ad2efd
to
365ddeb
Compare
…ted guide Also add some links
vomindoraan
force-pushed
the
newbs_getting_started_wording
branch
from
365ddeb
to
77d4ed1
Compare
noroadsleft
approved these changes
Nov 4, 2018
|
If someone could label this with |
drashna
reviewed
Nov 4, 2018
drashna
reviewed
Nov 4, 2018
drashna
reviewed
Nov 4, 2018
mechmerlin
reviewed
Nov 4, 2018
Co-Authored-By: vomindoraan <[email protected]>
Co-Authored-By: MechMerlin <[email protected]>
|
Should we add a note telling people to join the QMK Discord if they're having trouble with the setup? |
|
Yes, definitely. And worst case, I'll end up doing a lot more remote support |
|
Actually, I just saw that the Newbs guide index links to the Getting Help page, so I don't think we need to add a Discord link in here as well. This PR should be to go. |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Nov 9, 2018
* 'master' of https://github.com/qmk/qmk_firmware: (95 commits) Keymap: dlg's tada68 keymap (qmk#4289) relocate 40percent.club boards to new parent folder (qmk#4380) Keyboard: Add 30wer config and keymap (qmk#4386) Keyboard: fix ifdef for crkbd's default/keymap.c Add Layout-b for GH60 satan (qmk#4123) Fix misspelled make option, format rules.mk files (qmk#4382) Configurable Rainbow Swirl range (qmk#4376) Add xd75/billypython keymap (qmk#4381) Add Tragicforce 68 layout for split backspace and add configurator layouts (qmk#4378) Port over Noxary 268.2 from Rosakiin's Noxary Firmware (qmk#4354) Improve wording, punctuation and capitalization in newbs_getting_started guide (qmk#4342) Commit my DZ60 keymap (qmk#4375) Add whitefox/billypython keymap (qmk#4374) Helix-serial.c configuration improvement (qmk#4370) separated all my changes into separate files, working on generalizing my relativity macros. (qmk#4368) Zinc : Update to latest serial.c qmk#4278 (qmk#4361) Add localized LED flash effect on keypress to Massdrop ALT (qmk#4340) Fix Spacing issue in makefile that breaks Terminal config mapdev's Espectro layout (qmk#4366) command.h include was not set correctly ...
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Nov 17, 2018
…ted guide (qmk#4342) * Improve wording, punctuation and capitalization in newbs_getting_started guide Also add some links * Update example build command output Co-Authored-By: vomindoraan <[email protected]> * Replace occurrences of "layout" with "keymap" Co-Authored-By: MechMerlin <[email protected]> * Explicitly instruct users to open an MSYS2 MinGW 64-bit terminal * MSYS2 Console → MSYS2 MinGW * Replace thin spaces with regular spaces
cd-glacier
pushed a commit
to cd-glacier/qmk_firmware
that referenced
this pull request
Nov 26, 2018
…ted guide (qmk#4342) * Improve wording, punctuation and capitalization in newbs_getting_started guide Also add some links * Update example build command output Co-Authored-By: vomindoraan <[email protected]> * Replace occurrences of "layout" with "keymap" Co-Authored-By: MechMerlin <[email protected]> * Explicitly instruct users to open an MSYS2 MinGW 64-bit terminal * MSYS2 Console → MSYS2 MinGW * Replace thin spaces with regular spaces
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
…ted guide (qmk#4342) * Improve wording, punctuation and capitalization in newbs_getting_started guide Also add some links * Update example build command output Co-Authored-By: vomindoraan <[email protected]> * Replace occurrences of "layout" with "keymap" Co-Authored-By: MechMerlin <[email protected]> * Explicitly instruct users to open an MSYS2 MinGW 64-bit terminal * MSYS2 Console → MSYS2 MinGW * Replace thin spaces with regular spaces
djthread
pushed a commit
to djthread/qmk_firmware
that referenced
this pull request
Mar 17, 2019
…ted guide (qmk#4342) * Improve wording, punctuation and capitalization in newbs_getting_started guide Also add some links * Update example build command output Co-Authored-By: vomindoraan <[email protected]> * Replace occurrences of "layout" with "keymap" Co-Authored-By: MechMerlin <[email protected]> * Explicitly instruct users to open an MSYS2 MinGW 64-bit terminal * MSYS2 Console → MSYS2 MinGW * Replace thin spaces with regular spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some links