-
-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up keycode.h #3666
Merged
Merged
Tidy up keycode.h #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Aug 16, 2018
tmk_core/common/keycode.h
Outdated
KC_FN13, | ||
KC_FN14, | ||
KC_FN15, | ||
KC_FN16 //0xD0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot a comma here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I did, whoops. Fixed.
drashna
approved these changes
Aug 16, 2018
Nice - thanks! |
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Aug 17, 2018
* Tidy up keycode.h * Fix spacing here * Add back this comma
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* Tidy up keycode.h * Fix spacing here * Add back this comma
akatrevorjay
added a commit
to akatrevorjay/qmk_firmware
that referenced
this pull request
Oct 8, 2018
* 'master' of git://github.com/qmk/qmk_firmware: (620 commits) First pass at reorganizing docs Tidy up keycode.h (qmk#3666) Keyboard: DC60 Support (qmk#3667) change messege at 'check-size' target Add Atreus as an official board. Keyboard: Eagle/Viper V2 refactor and Configurator update (qmk#3671) fix line endings Keyboard: add ergoinu keyboard (qmk#3655) Keymap: Adding broswen keymap for iris split keyboard. (qmk#3654) Keyboard: Update AL1 default keycaps to new QMK standards (qmk#3675) Keymap: Revamp replicaJunction keymaps (qmk#3589) Keyboard: add generic ortho 5x14 layout support to Viterbi (qmk#3658) Keymap: Adding readme file to personal keymap folder (qmk#3665) Keyboard: dactyl manuform 6x6 added (qmk#3662) Add configurator support for 66_ansi layout for rev1, 2 and 3 this commit fixes qmk#3643, rev2 was affected too Docs: Update image in FAQ/Keymap: KC_EQLS -> KC_EQL (qmk#3660) Layouts: Add default ortho 5x14 layout (qmk#3656) Keymap: Helix : Update froggy keymap (qmk#3652) Keyboard: Added layout LAYOUT_60_ansi_split_bksp_rshift to ok60 (qmk#3644) ...
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Tidy up keycode.h * Fix spacing here * Add back this comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the indentation to 2 spaces as per the coding conventions. Also ordered and grouped the shortcut keycodes (
KC_XXXX
) in order of appearance.