Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up keycode.h #3666

Merged
merged 3 commits into from
Aug 16, 2018
Merged

Tidy up keycode.h #3666

merged 3 commits into from
Aug 16, 2018

Conversation

fauxpark
Copy link
Member

Changed the indentation to 2 spaces as per the coding conventions. Also ordered and grouped the shortcut keycodes (KC_XXXX) in order of appearance.

KC_FN13,
KC_FN14,
KC_FN15,
KC_FN16 //0xD0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot a comma here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I did, whoops. Fixed.

@jackhumbert
Copy link
Member

Nice - thanks!

@jackhumbert jackhumbert merged commit 700aa8f into qmk:master Aug 16, 2018
alexey-danilov pushed a commit to alexey-danilov/qmk_firmware that referenced this pull request Aug 17, 2018
* Tidy up keycode.h

* Fix spacing here

* Add back this comma
@fauxpark fauxpark deleted the tidy-keycode-h branch August 20, 2018 05:08
ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Sep 25, 2018
* Tidy up keycode.h

* Fix spacing here

* Add back this comma
akatrevorjay added a commit to akatrevorjay/qmk_firmware that referenced this pull request Oct 8, 2018
* 'master' of git://github.com/qmk/qmk_firmware: (620 commits)
  First pass at reorganizing docs
  Tidy up keycode.h (qmk#3666)
  Keyboard: DC60 Support (qmk#3667)
  change messege at 'check-size' target
  Add Atreus as an official board.
  Keyboard: Eagle/Viper V2 refactor and Configurator update (qmk#3671)
  fix line endings
  Keyboard: add ergoinu keyboard (qmk#3655)
  Keymap: Adding broswen keymap for iris split keyboard. (qmk#3654)
  Keyboard: Update AL1 default keycaps to new QMK standards (qmk#3675)
  Keymap: Revamp replicaJunction keymaps (qmk#3589)
  Keyboard:  add generic ortho 5x14 layout support to Viterbi (qmk#3658)
  Keymap: Adding readme file to personal keymap folder (qmk#3665)
  Keyboard: dactyl manuform 6x6 added (qmk#3662)
  Add configurator support for 66_ansi layout for rev1, 2 and 3
  this commit fixes qmk#3643, rev2 was affected too
  Docs: Update image in FAQ/Keymap: KC_EQLS -> KC_EQL (qmk#3660)
  Layouts: Add default ortho 5x14 layout (qmk#3656)
  Keymap: Helix : Update froggy keymap (qmk#3652)
  Keyboard: Added layout LAYOUT_60_ansi_split_bksp_rshift to ok60 (qmk#3644)
  ...
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
* Tidy up keycode.h

* Fix spacing here

* Add back this comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants