Add keyboards/whitefox/keymaps/constexpr #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Aug 1, 2018
| TAP_DANCE_ENABLE = yes | ||
| UNICODE_ENABLE = yes | ||
|
|
||
| ifndef QUANTUM_DIR |
There was a problem hiding this comment.
This block is a hold over from an older makefile configuration. If you could remove it?
There was a problem hiding this comment.
I was wondering about this. Sure thing, I'll do that right away.
| @@ -0,0 +1,19 @@ | |||
| #ifndef CONFIG_USER_H | |||
There was a problem hiding this comment.
Could you remove the first three lines and the #endif at the end and use just #pragma once
Eg, remove this:
#ifndef CONFIG_USER_H
#define CONFIG_USER_H
#include "../../config.h"
And the #endif at the end.
|
And the username is fine. Using the github account name is just a recommendation, not a requirement. |
drashna
approved these changes
Aug 1, 2018
|
Awesome, thanks! |
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Aug 3, 2018
* Add keyboards/whitefox/keymaps/constexpr * Conform to project coding conventions * Tweak numpad layer keys * Remove unnecessary directives
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* Add keyboards/whitefox/keymaps/constexpr * Conform to project coding conventions * Tweak numpad layer keys * Remove unnecessary directives
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Add keyboards/whitefox/keymaps/constexpr * Conform to project coding conventions * Tweak numpad layer keys * Remove unnecessary directives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My WhiteFox/NightFox keymap.
I used my GeekHack username as I don't really go by vomindoraan in the keyboard community. If it's customary to use GitHub usernames, let me know and I'll rename the folder.