Fix some minor errors in tap dance example #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #3529 Fix minor errors in the code examples for __Example 4: 'Quad Function Tap-Dance'__ and relevant documentation. Clarified the need to include the header file in `keymap.c`.
drashna
requested changes
Jul 31, 2018
docs/feature_tap_dance.md
Outdated
|
|
||
| You will need a few things in this file: | ||
|
|
||
| ```c | ||
| #ifndef YOUR_NAME | ||
| #define YOUR_NAME | ||
| #endif |
There was a problem hiding this comment.
This #endif isn't supported to be here.
Though, the entire top block could/should be replaced with #pragma once.
drashna
approved these changes
Aug 1, 2018
|
Awesome, thanks! |
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Aug 3, 2018
* Fix some minor errors in tap dance example Fix for qmk#3529 Fix minor errors in the code examples for __Example 4: 'Quad Function Tap-Dance'__ and relevant documentation. Clarified the need to include the header file in `keymap.c`. * Use #pragma once in header guard Fix for qmk#3529 Implement change requested in qmk#3530
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* Fix some minor errors in tap dance example Fix for qmk#3529 Fix minor errors in the code examples for __Example 4: 'Quad Function Tap-Dance'__ and relevant documentation. Clarified the need to include the header file in `keymap.c`. * Use #pragma once in header guard Fix for qmk#3529 Implement change requested in qmk#3530
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Fix some minor errors in tap dance example Fix for qmk#3529 Fix minor errors in the code examples for __Example 4: 'Quad Function Tap-Dance'__ and relevant documentation. Clarified the need to include the header file in `keymap.c`. * Use #pragma once in header guard Fix for qmk#3529 Implement change requested in qmk#3530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3529
Fix minor errors in the code examples for Example 4: 'Quad Function Tap-Dance' and relevant documentation.
Clarified the need to include the header file in
keymap.c.