Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor symbols layer with layer tap workaround #3520

Merged
merged 3 commits into from
Aug 2, 2018
Merged

Refactor symbols layer with layer tap workaround #3520

merged 3 commits into from
Aug 2, 2018

Conversation

skewwhiffy
Copy link
Contributor

No description provided.

@skewwhiffy
Copy link
Contributor Author

#3265

As a result of this discussion. have refactored the symbols layer asterix to use the number pad asterix in my XD75 layer.

Also some small changes:

  • Added number pad keys to UK keycodes so that UK users can exclusively use UK keycodes.
  • Squashed my layout a little bit so that it would fit on a Planck. To prepare for buying a Planck, obviously.

@skewwhiffy skewwhiffy mentioned this pull request Jul 29, 2018
Closed
drashna
drashna requested changes Jul 29, 2018
View reviewed changes
.gitignore Outdated
@@ -53,6 +53,7 @@ util/Win_Check_Output.txt
.vscode/tasks.json
.vscode/last.sql
.vscode/temp.sql
.vscode/settings.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

.vscode/settings.json Outdated
@@ -1,17 +0,0 @@
// Place your settings in this file to overwrite default and user settings.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you re-add this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@drashna drashna added the keymap label Jul 29, 2018
@skewwhiffy
Copy link
Contributor Author

skewwhiffy commented Aug 2, 2018 •
edited
Loading

@drashna Reverted the VS Code settings changes, and rebased on latest master: sorry, must have committed those by accident.

@drashna
Copy link
Member

drashna commented Aug 2, 2018

Not a problem, it happens! But thanks!

@drashna
Copy link
Member

drashna commented Aug 2, 2018

Thanks!

@drashna drashna merged commit 6c20c62 into qmk:master Aug 2, 2018
alexey-danilov pushed a commit to alexey-danilov/qmk_firmware that referenced this pull request Aug 3, 2018
@skewwhiffy
Keymap: Refactor symbols layer with layer tap workaround (qmk#3520)
b6d39a4 
* Squash layout to fit on Planck

* Replace AST with PAST keycode so that it works with layer tap

* Review markups
ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Sep 25, 2018
@skewwhiffy @ChrissiQ
Keymap: Refactor symbols layer with layer tap workaround (qmk#3520)
5c932a2 
* Squash layout to fit on Planck

* Replace AST with PAST keycode so that it works with layer tap

* Review markups
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
@skewwhiffy @yamad
Keymap: Refactor symbols layer with layer tap workaround (qmk#3520)
01662eb 
* Squash layout to fit on Planck

* Replace AST with PAST keycode so that it works with layer tap

* Review markups
@skewwhiffy skewwhiffy deleted the PrepareForPlanck branch May 9, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skewwhiffy @drashna