Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keymap: Fate Iris Layout #3508

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Keymap: Fate Iris Layout #3508

merged 1 commit into from
Jul 31, 2018

Conversation

FateNozomi
Copy link
Contributor

No description provided.

along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#ifndef CONFIG_USER_H
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace the boilerplate with just #pragma once.

Specifically, replace:

#ifndef CONFIG_USER_H
#define CONFIG_USER_H

#include "config_common.h"

And the #endif at the end with #pragma once

@@ -0,0 +1,128 @@
#include "iris.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace all the includes with #include QMK_KEYBOARD_H


To generate this bootloader, run:

make iris/rev2:fate:bootloader
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, :production is better. It generates both the firmware and the bootloader, actually, AND it creates a HEX that has both the bootloader and the firmware. So you ISP flash the production HEX, and the board is ready to use immediately

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using male jumper wires directly onto the Iris PCB through-holes for ISP programming without any soldering. So, I had to apply pressure between the jumper wires and PCB to keep the connection secure. Thus, I generated the bootloader only, because I wanted to minimize the time spent of ISP flashing. I'll update this anyway so thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that I can totally understand. But that's also why I soldered a header onto mine. :)

@FateNozomi
Copy link
Contributor Author

@drashna I've implemented the requested changes. Thanks!

@drashna
Copy link
Member

drashna commented Jul 31, 2018

Thanks!

@drashna drashna merged commit aee0f3c into qmk:master Jul 31, 2018
@FateNozomi FateNozomi deleted the iris branch July 31, 2018 14:11
alexey-danilov pushed a commit to alexey-danilov/qmk_firmware that referenced this pull request Aug 3, 2018
ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Sep 25, 2018
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants