-
-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keymap: Fate Iris Layout #3508
Keymap: Fate Iris Layout #3508
Conversation
keyboards/iris/keymaps/fate/config.h
Outdated
along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
#ifndef CONFIG_USER_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you replace the boilerplate with just #pragma once
.
Specifically, replace:
#ifndef CONFIG_USER_H
#define CONFIG_USER_H
#include "config_common.h"
And the #endif
at the end with #pragma once
keyboards/iris/keymaps/fate/keymap.c
Outdated
@@ -0,0 +1,128 @@ | |||
#include "iris.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace all the includes with #include QMK_KEYBOARD_H
|
||
To generate this bootloader, run: | ||
|
||
make iris/rev2:fate:bootloader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, :production
is better. It generates both the firmware and the bootloader, actually, AND it creates a HEX that has both the bootloader and the firmware. So you ISP flash the production HEX, and the board is ready to use immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using male jumper wires directly onto the Iris PCB through-holes for ISP programming without any soldering. So, I had to apply pressure between the jumper wires and PCB to keep the connection secure. Thus, I generated the bootloader only, because I wanted to minimize the time spent of ISP flashing. I'll update this anyway so thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that I can totally understand. But that's also why I soldered a header onto mine. :)
17bd222
to
eba633a
Compare
@drashna I've implemented the requested changes. Thanks! |
Thanks! |
No description provided.