Add caps lock led support to DZ60 #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cheers for requesting. Also, for posterity, much love #5253. |
drashna
requested changes
Jul 27, 2018
keyboards/dz60/dz60.c
Outdated
| @@ -26,3 +26,13 @@ void led_set_kb(uint8_t usb_led) { | |||
| // Set this per keymap, instead of globally | |||
| led_set_user(usb_led); | |||
| } | |||
|
|
|||
| void led_set_user(uint8_t usb_led) { | |||
There was a problem hiding this comment.
This block really should be in led_set_kb
|
Could you make sure that |
|
Your wish is my command. =P |
drashna
approved these changes
Jul 29, 2018
|
Thanks. :D |
mattfluder
pushed a commit
to mattfluder/qmk_firmware
that referenced
this pull request
Jul 30, 2018
* add caps lock led support to DZ60 * changes from drashna's code review comments * call led_set_user at the end of led_set_kb
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Aug 3, 2018
* add caps lock led support to DZ60 * changes from drashna's code review comments * call led_set_user at the end of led_set_kb
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* add caps lock led support to DZ60 * changes from drashna's code review comments * call led_set_user at the end of led_set_kb
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* add caps lock led support to DZ60 * changes from drashna's code review comments * call led_set_user at the end of led_set_kb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't believe this hasn't been reported until now! lol!