Untangle layouts for Dimple rev3 and Infinity87 #18462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dimple user keymap failures here are expected; they are written for rev1/2. |
drashna
approved these changes
Sep 24, 2022
tacahiroy
pushed a commit
to tacahiroy/qmk_firmware
that referenced
this pull request
Oct 2, 2022
aivalja
pushed a commit
to aivalja/qmk_firmware
that referenced
this pull request
Nov 7, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the relevant error_page failures (ie. Configurator builds) due to layout macro information existing at multiple levels and the wrong one being picked up:
Or the correct layout macro not existing in the file it does pick up:
Types of Changes
Issues Fixed or Closed by This PR
Checklist