Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymaps: add kinesis/keymaps/jwon #13618

Merged
merged 27 commits into from
Jul 24, 2021
Merged

keymaps: add kinesis/keymaps/jwon #13618

merged 27 commits into from
Jul 24, 2021

Conversation

jwon
Copy link

@jwon jwon commented Jul 20, 2021

Description

Created my own personal keymap for the Kinesis Advantage 2 using the Stapelberg mod.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/kinesis/keymaps/jwon/config.h Outdated Show resolved Hide resolved
keyboards/kinesis/keymaps/jwon/keymap.c Show resolved Hide resolved
keyboards/kinesis/keymaps/jwon/keymap.c Outdated Show resolved Hide resolved
@jwon
Copy link
Author

jwon commented Jul 22, 2021

Thank you for the feedback @drashna !

I made the changes you suggested. Can you please take another look?

@drashna drashna requested a review from a team July 22, 2021 17:45
keyboards/kinesis/keymaps/jwon/config.h Outdated Show resolved Hide resolved
keyboards/kinesis/keymaps/jwon/rules.mk Outdated Show resolved Hide resolved
@jwon
Copy link
Author

jwon commented Jul 22, 2021

@fauxpark I made the changes you requested. Can you please take another look? Thank you very much!

@jwon jwon requested a review from fauxpark July 22, 2021 22:32
@drashna drashna requested a review from a team July 23, 2021 01:54
keyboards/kinesis/keymaps/jwon/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team July 23, 2021 15:59
@drashna
Copy link
Member

drashna commented Jul 24, 2021

Thanks!

@drashna drashna merged commit 44a0aa9 into qmk:master Jul 24, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 24, 2021
* qmk/develop: (33 commits)
  [Keyboard] Add Keychron Q1 (qmk#13397)
  [Keymap] add kinesis/keymaps/jwon (qmk#13618)
  [Keyboard] Dharma (qmk#13663)
  feature: Add swap hands support for sofle keyboard. (qmk#13654)
  Fix up xd002 rgb keymaps (qmk#13685)
  Avoid LTO conficts on arm_atsam (qmk#13676)
  [Keyboard] Reduce compile size for dz60rgb v2.1 (qmk#13680)
  [Keyboard] Fix type on pandora via keymap (qmk#13681)
  Remove deprecated callbacks for encoders and dip switches (qmk#13404)
  [Keyboard] Quick hack to fix Astro65 board (qmk#13665)
  [Keyboard] Added Compound keyboard support (qmk#12942)
  Disables rgblight twinkle by default. (qmk#13677)
  [Keyboard] Fix split matrix for sekigon grs 70ec (qmk#13672)
  [Keyboard] Fix matrix delay on Drop boards (qmk#13671)
  [Keyboard] Disable console by default on all Keebio boards (qmk#13649)
  CLI/Docs: Fix the format commands' name (qmk#13668)
  [Keyboard] Enable LTO by default on BastardKB Scylla (qmk#13664)
  [Keyboard] Fix symmetric70_proto build break on develop branch (qmk#13667)
  [Keyboard] Remove broken, unmaintained converter/ibm_5291 (qmk#13658)
  [Keyboard] Add model-v keyboard (qmk#13643)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants