Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix consistency improvements #13471

Merged
merged 1 commit into from
Jul 11, 2021
Merged

Matrix consistency improvements #13471

merged 1 commit into from
Jul 11, 2021

Conversation

skullydazed
Copy link
Member

Description

While working on #13470 I noticed a lot of keyboards have MATRIX_ROWS and MATRIX_COLS that are inconsistent with the pins actually configured to be used. This PR attempts to correct that in most cases.

TODO:

  • Check that boards still compile
  • Check that boards that need virtual rows/cols still work with the NO_PIN addition

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team July 6, 2021 17:38
@skullydazed skullydazed marked this pull request as ready for review July 11, 2021 15:41
@skullydazed skullydazed merged commit adf0d70 into develop Jul 11, 2021
@Xelus22 Xelus22 mentioned this pull request Jul 19, 2021
Merged
14 tasks
@fauxpark fauxpark deleted the matrix_consistency_improvements branch August 3, 2021 10:17
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@skullydazed @nhongooi
first pass: matrix consistency improvements (qmk#13471)
a58b5a7
MMcM added a commit to MMcM/qmk_firmware that referenced this pull request Feb 28, 2022
@MMcM
converter/ibm_5291
ae2772b 
* Restore code from qmk#4483 to working order.
* qmk#13471 changed MATRIX_ROW_PINS to avoid warnings, rather than realizing that it didn't mean the same thing.
* qmk#13658 then removed it because it wouldn't compile after that.
* So, instead rename the PIN macros to not conflict with regular matrix scanning.
MMcM added a commit to MMcM/qmk_firmware that referenced this pull request May 29, 2022
@MMcM
converter/ibm_5291
6cc54e6 
* Restore code from qmk#4483 to working order.
* qmk#13471 changed MATRIX_ROW_PINS to avoid warnings, rather than realizing that it didn't mean the same thing.
* qmk#13658 then removed it because it wouldn't compile after that.
* So, instead rename the PIN macros to not conflict with regular matrix scanning.
MMcM added a commit to MMcM/qmk_firmware that referenced this pull request Oct 22, 2022
@MMcM
converter/ibm_5291
0ed7838 
* Restore code from qmk#4483 to working order.
* qmk#13471 changed MATRIX_ROW_PINS to avoid warnings, rather than realizing that it didn't mean the same thing.
* qmk#13658 then removed it because it wouldn't compile after that.
* So, instead rename the PIN macros to not conflict with regular matrix scanning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skullydazed @fauxpark