Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow raw coverage files with same name #1424

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

marschattha
Copy link
Member

@marschattha marschattha commented Jan 13, 2025

Right now if someone has two coverage files with same name in different directories it throws the error: invalid Zip archive: Duplicate filename

Adding dir path to zip should prevent that while maintaining uniqueness in identifying files.

Reference: https://discord.com/channels/1256822430505373696/1308114848403685406/1328180907554766910

@marschattha marschattha requested review from brynary and lsegal January 13, 2025 19:42
Copy link
Contributor

qltysh bot commented Jan 13, 2025

The code coverage on the diff in this pull request is 100.0%

Drilldown
Path File Coverage Δ
qlty-check/src/tool/command_builder.rs 2.6
qlty-check/src/tool/ruby/sys/macos.rs 3.1
qlty-check/src/tool/download.rs 0.7
qlty-check/src/executor/driver.rs -0.9
qlty-check/src/tool/ruby/sys/linux.rs -1.6
qlty-cloud/src/export/coverage.rs -0.6

@tim-gq
Copy link

tim-gq commented Jan 13, 2025

💯 Thank you! Looking forward to seeing this shipped. 😄

@marschattha marschattha merged commit e6ba9f1 into main Jan 14, 2025
8 checks passed
@marschattha marschattha deleted the ma/allow_raw_coverage_files_with_same_name branch January 14, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants