Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export does not if no folder is opened in VSCode #19

Closed
paulbombarde opened this issue Jul 12, 2018 · 12 comments
Closed

Export does not if no folder is opened in VSCode #19

paulbombarde opened this issue Jul 12, 2018 · 12 comments

Comments

@paulbombarde
Copy link

Hello,

Since previous Code update (1.24.0), the export to file does not work anymore, whatever the format. Still ko after full reinstall of VSCode (1.25.0) with only markdown-extended extension freshly installed.

I tried setting the puppeteer executable path without luck. Other similar extensions (Markdown to pdf) that also rely on puppeteer do work correctly (but do not support all the same feature you do).

I'm on win10. Is there any debug info I can get to see what happening ?
Best regards,
Paul

@qjebbs
Copy link
Owner

qjebbs commented Jul 12, 2018

Any error messages? I tested good, with 1.25.0, but on mac.

PS: the exported files are organized in out dir.

@paulbombarde
Copy link
Author

No error messages. The pop-up appears, with the running indicatior spinning under for a less than a second, then the pop-up disappear silently. No extra pop-up for success or failure.

There is no out directory created either. I tried to create it before running the export, but no luck.

@qjebbs
Copy link
Owner

qjebbs commented Jul 12, 2018

cannot reproduce, works good here 1.25.0 on win10

@paulbombarde
Copy link
Author

I tested with one of my collegue and he has the same issue. That may be linked to the windows 10 set up from our IT...

Do you have an idea on how to debug this ? I never touch VSCode extension code...

@qjebbs
Copy link
Owner

qjebbs commented Jul 13, 2018

  1. clone this project to local
  2. open it in vscode and in terminal: npm i
  3. pressF5 to start debug

@qjebbs
Copy link
Owner

qjebbs commented Jul 13, 2018

You told that export doesn't work for any formats, but I guess it works at least for html, since html export doesn't rely on puppeteer.

@paulbombarde
Copy link
Author

It does not work either for html. That really strange. I'm trying a quick debug session.

@paulbombarde
Copy link
Author

Got it : I don't always open folders in VSCode, especially when I want to quickly generate a pdf from a md file : I have configured windows to open md file in VSCode.

In export.js l.30 :

    if (!vscode.workspace.workspaceFolders) { return []; }

If I open a folder before launching the export, everything is ok.

@paulbombarde paulbombarde changed the title Export does not work anymore Export does not if no folder is opened in VSCode Jul 13, 2018
@qjebbs
Copy link
Owner

qjebbs commented Jul 14, 2018

Thanks! It's my mistake, please update.

@paulbombarde
Copy link
Author

If you want, I'll send a PR next week. Just tell me.

@paulbombarde
Copy link
Author

Ok, I saw this update. :+1

@qjebbs qjebbs closed this as completed Jul 15, 2018
@paulbombarde
Copy link
Author

Correction confirmed. Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants