Fix unit test of GroverOptimizer#96
Merged
manoelmarques merged 7 commits intoqiskit-community:mainfrom Apr 23, 2021
Merged
Conversation
a-matsuo
requested review from
manoelmarques,
pbark,
stefan-woerner,
t-imamichi and
woodsp-ibm
as code owners
Collaborator
|
I don't think it's a good idea to change the unit test to pass. We need to fix the algorithm. |
Contributor
Author
|
Sure. I fixed the algorithm and also fixed the unit test setting (Actually, the former setting was inappropriate). |
a-matsuo
added a commit
to a-matsuo/qiskit-optimization
that referenced
this pull request
Apr 23, 2021
a-matsuo
added a commit
to a-matsuo/qiskit-optimization
that referenced
this pull request
Apr 23, 2021
woodsp-ibm
added
the
stable backport potential
woodsp-ibm
approved these changes
Apr 23, 2021
t-imamichi
approved these changes
Apr 23, 2021
mergify Bot
pushed a commit
that referenced
this pull request
Apr 23, 2021
* fix unittest of grover optimizer * fix * fix lint * fix unittest and timing of updating samples * clean up * fix lint Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> (cherry picked from commit 7a7784f)
manoelmarques
pushed a commit
that referenced
this pull request
Apr 23, 2021
* fix unittest of grover optimizer * fix * fix lint * fix unittest and timing of updating samples * clean up * fix lint Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> (cherry picked from commit 7a7784f) Co-authored-by: a-matsuo <47442626+a-matsuo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #88
Details and comments
As mentioned in #88, somehow, we get the different results even with the same seed. This issue didn't occur before.
I used a different example for the unit test and I get the same result in that case.