Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to new Ecosystem theme. #562

Merged
merged 3 commits into from
Oct 15, 2023

Conversation

arnaucasau
Copy link
Contributor

@arnaucasau arnaucasau commented Sep 28, 2023

Summary

Updates to new Ecosystem theme.

Total file size increased (4.76 MB → 5.36 MB)
index.html size increased (15 KB → 40.2 KB)
Build time increased (47s → 52s)

For more information: Qiskit/qiskit_sphinx_theme#232

@coveralls
Copy link

coveralls commented Sep 28, 2023

Pull Request Test Coverage Report for Build 6511002758

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.028%

Totals Coverage Status
Change from base Build 6505092051: 0.0%
Covered Lines: 4510
Relevant Lines: 4848

💛 - Coveralls

@arnaucasau arnaucasau marked this pull request as ready for review October 13, 2023 12:39
@woodsp-ibm
Copy link
Member

In Qiskit Nature I note that you changed SubModule heading level - presumably so SubModule does not come out in left navigation sidebar. Does that need doing here - e.g. this one

@arnaucasau
Copy link
Contributor Author

Yes, that's right, thank you for your comment Steve! I have also noticed that happening with different entries as well (without changing the heading level there are multiple entries in the menu to the same page). I fixed it in this last commit, let me know what you think, and I will do the same with qiskit-machine-learning, and check again qiskit-nature if you want, of course.

@Eric-Arellano
Copy link
Contributor

Thanks @t-imamichi! Arnau doesn't have write access, so this will need a merge from a maintainer.

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end I guess it comes down to what people/users expect - if things are consistent this way across the various projects I guess its fine. It does flatten things out and loses some of the structure this way. In qiskit-algorithms the algorithms main page has several sections for different types which done this way they will all appear in a single list - though the list is in the same order so if you know more what you are looking for. I guess there is a tension though with the right sidebar that shows that level of structure but not the detail under it (that which is flattened out in the left hand side). Lets go with this and have things done consistent like this - it seems the heading level changes are simple enough to revisited if it seems desired in the future.

@mergify mergify bot merged commit e620f08 into qiskit-community:main Oct 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants