-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to new Ecosystem theme. #562
Updates to new Ecosystem theme. #562
Conversation
Co-authored-by: Frank Harkins <[email protected]>
Pull Request Test Coverage Report for Build 6511002758
💛 - Coveralls |
In Qiskit Nature I note that you changed SubModule heading level - presumably so SubModule does not come out in left navigation sidebar. Does that need doing here - e.g. this one qiskit-optimization/qiskit_optimization/algorithms/__init__.py Lines 65 to 66 in cddfbbb
|
Yes, that's right, thank you for your comment Steve! I have also noticed that happening with different entries as well (without changing the heading level there are multiple entries in the menu to the same page). I fixed it in this last commit, let me know what you think, and I will do the same with qiskit-machine-learning, and check again qiskit-nature if you want, of course. |
Thanks @t-imamichi! Arnau doesn't have write access, so this will need a merge from a maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end I guess it comes down to what people/users expect - if things are consistent this way across the various projects I guess its fine. It does flatten things out and loses some of the structure this way. In qiskit-algorithms the algorithms main page has several sections for different types which done this way they will all appear in a single list - though the list is in the same order so if you know more what you are looking for. I guess there is a tension though with the right sidebar that shows that level of structure but not the detail under it (that which is flattened out in the left hand side). Lets go with this and have things done consistent like this - it seems the heading level changes are simple enough to revisited if it seems desired in the future.
Summary
Updates to new Ecosystem theme.
Total file size increased (4.76 MB → 5.36 MB)
index.html size increased (15 KB → 40.2 KB)
Build time increased (47s → 52s)
For more information: Qiskit/qiskit_sphinx_theme#232