update setup.py to use requirements.txt#56
update setup.py to use requirements.txt#56manoelmarques merged 4 commits intoqiskit-community:masterfrom
Conversation
ikkoham
requested review from
pbark,
stefan-woerner and
woodsp-ibm
as code owners
This reverts commit c0d92a1.
|
I agree with this change, however the PR #45 adds the following line to requirements.txt: This is one of those flags that only works on requirements.txt but will fail on setup.py. If that PR goes ahead with that then we cannot use requirements.txt in setup.py. I will add a hold to this PR pending a decision next meeting. |
|
I think gurobi should be extra_required. Then, it is not included requirements.txt and this PR works. |
|
Unfortunately because gurobipy is hosted on a private pypi site, it doesn’t work in setup.py via setuptools for security reasons. It can’t currently be in install_requires or extra_required. I will probably just remove it from requirements.txt in the other PR and then approve this one. |
|
I have a worry to include a private pypi site in requirements.txt because our CI may fail due to their server error. Users may fail installation of qiskit-optimization. But, we are not responsible for the private pypi site... |
|
Exactly, that is why I want to remove it from requirements.txt in the other PR and let the users install themselves. |
3 participants
Summary
Update setup.py to use requirements.txt.
This is discussed in Terra Qiskit/qiskit#1586.
Details and comments