Skip to content

Adopt lazy imports from Terra#343

Merged
manoelmarques merged 1 commit into
qiskit-community:mainfrom
manoelmarques:lazy
Mar 4, 2022
Merged

Adopt lazy imports from Terra#343
manoelmarques merged 1 commit into
qiskit-community:mainfrom
manoelmarques:lazy

Conversation

@manoelmarques
Copy link
Copy Markdown
Contributor

@manoelmarques manoelmarques commented Mar 4, 2022

Summary

Adopt the API implemented in Qiskit/qiskit#7525

Details and comments

@manoelmarques manoelmarques added type: enhancement run_slow PR will run all unit tests decorated as slow labels Mar 4, 2022
@manoelmarques manoelmarques self-assigned this Mar 4, 2022
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 4, 2022

Pull Request Test Coverage Report for Build 1934823675

  • 30 of 34 (88.24%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 90.989%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_optimization/algorithms/cplex_optimizer.py 2 3 66.67%
qiskit_optimization/algorithms/gurobi_optimizer.py 3 4 75.0%
qiskit_optimization/translators/gurobipy.py 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
qiskit_optimization/applications/graph_optimization_application.py 1 81.48%
Totals Coverage Status
Change from base Build 1917408830: 0.3%
Covered Lines: 4059
Relevant Lines: 4461
💛 - Coveralls

@manoelmarques manoelmarques merged commit 2fc65b3 into qiskit-community:main Mar 4, 2022
@manoelmarques manoelmarques deleted the lazy branch March 4, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

@pbark pbark Awaiting requested review from pbark

@t-imamichi t-imamichi Awaiting requested review from t-imamichi t-imamichi is a code owner

Assignees

@manoelmarques manoelmarques

Labels

run_slow PR will run all unit tests decorated as slow type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manoelmarques @coveralls @woodsp-ibm