Skip to content

Adjust test_samples_qaoa for Terra#6828#218

Merged
mergify[bot] merged 3 commits into
qiskit-community:mainfrom
t-imamichi:terra-pr6828
Oct 8, 2021
Merged

Adjust test_samples_qaoa for Terra#6828#218
mergify[bot] merged 3 commits into
qiskit-community:mainfrom
t-imamichi:terra-pr6828

Conversation

@t-imamichi
Copy link
Copy Markdown
Collaborator

@t-imamichi t-imamichi commented Jul 30, 2021

Summary

This adjusts a unit test "test_samples_qaoa" to pass with Qiskit/qiskit#6828

Details and comments

  • I found that SLSQP gets stuck at a suboptimal point. So I replaced it with COBYLA.
  • I also slightly simplified the unit test by defining a problem directly by QP.
  • I removed the number of solution samples because they may vary, i.e., the solver converged very well to the optimal solution. We have tests to check the best solution has most likelihood. So, I think it's enough.

@t-imamichi
Copy link
Copy Markdown
Collaborator Author

t-imamichi commented Oct 8, 2021

Because Qiskit/qiskit#6828 is merged, we need to merge this PR. Otherwise, CI should fail at test_samples_qaoa. Could you review this PR @woodsp-ibm?

@woodsp-ibm woodsp-ibm removed the on hold Can not fix yet label Oct 8, 2021
@woodsp-ibm woodsp-ibm mentioned this pull request Oct 8, 2021
@mergify mergify Bot merged commit abb0cd1 into qiskit-community:main Oct 8, 2021
@t-imamichi t-imamichi deleted the terra-pr6828 branch October 8, 2021 17:13
@t-imamichi
Copy link
Copy Markdown
Collaborator Author

Thanks!

clausia pushed a commit to clausia/qiskit-optimization that referenced this pull request Dec 13, 2021
* adjust a unit test for terra#6828

* remove tests of number of samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants