Separate from_ising and to_ising out from QuadraticProgram#166
Merged
t-imamichi merged 12 commits intoqiskit-community:mainfrom Jun 18, 2021
Merged
Separate from_ising and to_ising out from QuadraticProgram#166t-imamichi merged 12 commits intoqiskit-community:mainfrom
from_ising and to_ising out from QuadraticProgram#166t-imamichi merged 12 commits intoqiskit-community:mainfrom
Conversation
t-imamichi
requested review from
manoelmarques,
pbark,
stefan-woerner and
woodsp-ibm
as code owners
Contributor
stefan-woerner
left a comment
stefan-woerner
left a comment
There was a problem hiding this comment.
lgtm, let's discuss the type hints in the call later today
# Conflicts: # qiskit_optimization/translators/docplex_mp.py # qiskit_optimization/translators/gurobipy.py
Collaborator
Author
|
Thanks to #170, I simplified this PR to remove |
t-imamichi
added
the
Changelog: New feature
woodsp-ibm
reviewed
Jun 16, 2021
woodsp-ibm
reviewed
Jun 16, 2021
woodsp-ibm
reviewed
Jun 16, 2021
woodsp-ibm
reviewed
Jun 16, 2021
woodsp-ibm
reviewed
Jun 16, 2021
woodsp-ibm
previously approved these changes
Jun 17, 2021
Collaborator
Author
|
I'm afraid I didn't notice @woodsp-ibm's approval. I notice that we need to raise an error in |
t-imamichi
commented
Jun 17, 2021
woodsp-ibm
approved these changes
Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separated
from_isingandto_isingout fromQuadraticProgramby adding them as translators.Details and comments