Add missing black settings#172
Merged
mrossinek merged 2 commits intoqiskit-community:mainfrom May 6, 2021
Merged
Conversation
mrossinek
requested review from
manoelmarques,
pbark,
stefan-woerner and
woodsp-ibm
as code owners
pbark
previously approved these changes
May 6, 2021
mrossinek
commented
May 6, 2021
I grepped for '" "' because reviewing the 104 files likely exceeds the time worth spending on this. If I missed a single oddity somewhere we can fix it once we notice. The code works as is, anyways 👍
manoelmarques
approved these changes
May 6, 2021
Contributor
|
Thanks a lot for catching this @mrossinek. |
Anthony-Gandon
pushed a commit
to Anthony-Gandon/qiskit-nature
that referenced
this pull request
May 25, 2023
* Add missing black settings * Manual fixes I grepped for '" "' because reviewing the 104 files likely exceeds the time worth spending on this. If I missed a single oddity somewhere we can fix it once we notice. The code works as is, anyways 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
pyproject.tomlfile.Details and comments
The reason for many of the "odd" reformattings part of #171 is the missing configuration file.
Most notable, the missing settings for the line-length!
blackdefaults to a line-length of 88 which obviously caused many changes in our code-base (which uses a line-length of 100).