Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve syntax. #899

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Improve syntax. #899

merged 3 commits into from
Dec 27, 2022

Conversation

priti-ashvin-shah-ibm
Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm commented Dec 27, 2022

What are the issues this pull addresses (issue numbers / links)?

Use Skip install=true and EXPLICITLY identify the dependencies.

Did you add tests to cover your changes (yes/no)?

Did you update the documentation accordingly (yes/no)?

Did you read the CONTRIBUTING document (yes/no)?

Summary

Details and comments

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm marked this pull request as ready for review December 27, 2022 21:19
Copy link
Collaborator

@obrienpja obrienpja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will have to fix the structure of qiskit metal to better separate normal use cases from documentation building, so that we can remove requirements.txt from the tox.ini

@obrienpja obrienpja merged commit 91c21c5 into main Dec 27, 2022
@obrienpja obrienpja deleted the 855_2_req branch December 27, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants