Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version lock tox and update actions #889

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

obrienpja
Copy link
Collaborator

What are the issues this pull addresses (issue numbers / links)?

This PR version locks tox to address a breaking change. It also updates the versions of our GitHub Actions.

Did you add tests to cover your changes (yes/no)?

N/A

Did you update the documentation accordingly (yes/no)?

N/A

Did you read the CONTRIBUTING document (yes/no)?

N/A

Summary

N/A

Details and comments

N/A

@obrienpja
Copy link
Collaborator Author

I just want to be clear here that version locking tox was necessary for fixing our CI

@priti-ashvin-shah-ibm
Copy link
Collaborator

This also version locks the version of Ubuntu to 20.04 along with tox to git+https://github.com/tox-dev/[email protected]. Based on information from
actions/setup-python#570
and
actions/cache#1031.

Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm merged commit f1494eb into main Dec 22, 2022
@priti-ashvin-shah-ibm priti-ashvin-shah-ibm deleted the fix-pipeline branch December 22, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants