Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with self._uwave_package #829

Merged

Conversation

AbeerVaishnav13
Copy link
Collaborator

What are the issues this pull addresses (issue numbers / links)?

#828

Did you add tests to cover your changes (yes/no)?

No

Did you update the documentation accordingly (yes/no)?

No

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Fixes the issue with getting tuple instead of string for sample_holder_top in self._uwave_package

Details and comments

@AbeerVaishnav13 AbeerVaishnav13 linked an issue Aug 1, 2022 that may be closed by this pull request
Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good catch.

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm merged commit ea644a5 into main Aug 1, 2022
@priti-ashvin-shah-ibm priti-ashvin-shah-ibm deleted the 828-fix-self_uwave_package-in-multiplanar branch August 1, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix self._uwave_package in MultiPlanar
2 participants