Gmsh renderer #815
Merged
Gmsh renderer #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Gradient based mesh size fields - Functionality for user to define their own mesh size field function - Used already present toolbox functions instead of making my own
- TODO: recombine this with Vector in draw/utility.py
- Changed the renderer to use the new 3D vector in `qiskit_metal/draw/utility.py` - Used bad_fillet_idxs in `toolbox_python/utility_functions.py` to selectively fillet vertices
- Removed unused code - Added helpful TODO comments - Added physical group for each chip
AbeerVaishnav13
requested review from
priti-ashvin-shah-ibm,
ThomasGM4,
obrienpja and
zlatko-minev
- environment.yml - requirements.txt
- Added proper docstring for __init__ in gmsh_renderer.py - Added logger.info for custom meshing function
AbeerVaishnav13
force-pushed
the
gmsh_renderer
branch
from
06b433d to
8bb4d22
Compare
- Added exception handling for Gmsh GUI launch - Updated the notebook to have better readability - Updated environment.yml to have python-gmsh
This was referenced Aug 12, 2022
- Updated notebook - Bug fix for segmendted ground plane rendering
AbeerVaishnav13
force-pushed
the
gmsh_renderer
branch
from
7b13828 to
759e8bd
Compare
AbeerVaishnav13
force-pushed
the
gmsh_renderer
branch
from
1528984 to
0a4316b
Compare
ThomasGM4
approved these changes
Aug 12, 2022
priti-ashvin-shah-ibm
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
#814
Did you add tests to cover your changes (yes/no)?
Yes
Did you update the documentation accordingly (yes/no)?
Yes
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
Adding feature to render Qiskit Metal design in Gmsh. Use case for this feature is specified in detail in the related issue #814 .
Details and comments
This pull request might require series of reviews before finalizing and merging the changes. Forth-coming changes include:
QGmshRendererto connect withQElmerRenderer(done through a separate pull request)