Skip to content

Adopt lazy imports from Terra#152

Merged
manoelmarques merged 1 commit into
qiskit-community:mainfrom
manoelmarques:lazy
Mar 4, 2022
Merged

Adopt lazy imports from Terra#152
manoelmarques merged 1 commit into
qiskit-community:mainfrom
manoelmarques:lazy

Conversation

@manoelmarques
Copy link
Copy Markdown
Contributor

Summary

Adopt the API implemented in Qiskit/qiskit#7525

Details and comments

@manoelmarques manoelmarques added type: enhancement run_slow PR will run all unit tests decorated as slow labels Mar 4, 2022
@manoelmarques manoelmarques self-assigned this Mar 4, 2022
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1935136792

  • 4 of 4 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 83.514%

Totals Coverage Status
Change from base Build 1917410805: 0.8%
Covered Lines: 694
Relevant Lines: 831

💛 - Coveralls

@manoelmarques manoelmarques merged commit 63822de into qiskit-community:main Mar 4, 2022
@manoelmarques manoelmarques deleted the lazy branch March 4, 2022 21:02
@manoelmarques manoelmarques added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Aug 29, 2022
mergify Bot pushed a commit that referenced this pull request Aug 29, 2022
(cherry picked from commit 63822de)

# Conflicts:
#	qiskit_finance/data_providers/exchange_data_provider.py
#	qiskit_finance/data_providers/wikipedia_data_provider.py
mergify Bot added a commit that referenced this pull request Aug 29, 2022
* Adopt lazy imports from Terra (#152)

(cherry picked from commit 63822de)

# Conflicts:
#	qiskit_finance/data_providers/exchange_data_provider.py
#	qiskit_finance/data_providers/wikipedia_data_provider.py

* fix conflicts

Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_slow PR will run all unit tests decorated as slow stable backport potential The bug might be minimal and/or import enough to be port to stable type: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants