Integer-based Clifford operations for faster 1Q/2Q RB#907
Closed
itoko wants to merge 10 commits into
Closed
Conversation
Co-authored-by: merav-aharoni <46567124+merav-aharoni@users.noreply.github.com>
itoko
force-pushed
the
rb-integer-clifford
branch
from
3d22573 to
08c5743
Compare
Contributor
Author
|
Superseded by #940 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speed up 1Q/2Q RB by replacing slow Clifford operations (
composeandadjoint) with integer-based operations using pre-generated look-up tables.Details and comments
The integer Clifford idea was originally proposed by @merav-aharoni in #892 (including the layer decomposition for 2Q Clifford) .
This commit just implements the idea on top of the new code structure introduced by #898.
Co-authored-by: merav-aharoni 46567124+merav-aharoni@users.noreply.github.com