Compare sorted tags in test_save_all#709
Merged
Merged
Conversation
qiskit-experiments does not maintain order on experiment tags since qiskit-community#522 so we need to compare experiment tags in the `test_save_all` test with a predictable sort order. This was originally fixed in qiskit-ibm-provider: Qiskit/qiskit-ibm-provider#214 Closes qiskit-community#708
wshanks
approved these changes
Mar 4, 2022
chriseclectic
added
the
Changelog: Bugfix
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
qiskit-experiments does not maintain order on experiment tags since qiskit-community#522 so we need to compare experiment tags in the `test_save_all` test with a predictable sort order. This was originally fixed in qiskit-ibm-provider: Qiskit/qiskit-ibm-provider#214 Closes qiskit-community#708 Co-authored-by: Will Shanks <willshanks@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qiskit-experiments does not maintain order on experiment
tags since #522 so we need to compare experiment tags in
the
test_save_alltest with a predictable sort order.Details and comments
This was originally fixed in qiskit-ibm-provider:
Qiskit/qiskit-ibm-provider#214
Closes #708