Skip to content

Removed sub-experiment info from composite analysis result#603

Merged
yaelbh merged 5 commits into
qiskit-community:mainfrom
yaelbh:kids_in_analysis
Jan 13, 2022
Merged

Removed sub-experiment info from composite analysis result#603
yaelbh merged 5 commits into
qiskit-community:mainfrom
yaelbh:kids_in_analysis

Conversation

@yaelbh
Copy link
Copy Markdown
Collaborator

@yaelbh yaelbh commented Jan 11, 2022

Summary

Closes #590

Details and comments

@yaelbh
Copy link
Copy Markdown
Collaborator Author

yaelbh commented Jan 11, 2022

CI is failing because of #592 (not related to this PR)

Copy link
Copy Markdown
Collaborator

@chriseclectic chriseclectic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a release note with an upgrade note that the returned analysis results of Parallel and Batch experiment have changed.

@yaelbh
Copy link
Copy Markdown
Collaborator Author

yaelbh commented Jan 11, 2022

@chriseclectic Thanks for the reminder about the release notes, I've committed the notes, I hope it's OK

Copy link
Copy Markdown
Collaborator

@chriseclectic chriseclectic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to make release note more useful by including appropriate API doc links.

Comment thread releasenotes/notes/kids-in-analysis-df7b4dcbeb5b3125.yaml Outdated
@yaelbh yaelbh merged commit 74e2d91 into qiskit-community:main Jan 13, 2022
nkanazawa1989 pushed a commit to nkanazawa1989/qiskit-experiments that referenced this pull request Jan 19, 2022
…mmunity#603)

* Removed sub-experiment info from composite analysis result

* release notes

* Update releasenotes/notes/kids-in-analysis-df7b4dcbeb5b3125.yaml

Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>

* removed a debug print

Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
paco-ri pushed a commit to paco-ri/qiskit-experiments that referenced this pull request Jul 11, 2022
…mmunity#603)

* Removed sub-experiment info from composite analysis result

* release notes

* Update releasenotes/notes/kids-in-analysis-df7b4dcbeb5b3125.yaml

Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>

* removed a debug print

Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop storing child experiments in analysis result

2 participants