Skip to content

Improve ExperimentData handling of jobs and analysis #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chriseclectic merged 7 commits into from
Jan 20, 2022
Merged

Improve ExperimentData handling of jobs and analysis #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b03f9a4
Improve analysis callbacks
chriseclectic Jan 7, 2022
61adba2
Improve handling of job data futures
chriseclectic Jan 7, 2022
414c91e
Improve futures logging and waiting
chriseclectic Jan 10, 2022
4873374
Rename callback methods to use analysis naming
chriseclectic Jan 10, 2022
cbe7bcb
Add ExperimentStatus and AnalysisStatus enums
chriseclectic Jan 10, 2022
c0c0d0a
Address review comments
chriseclectic Jan 13, 2022
06d96ab
Review comments add tests
chriseclectic Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion qiskit_experiments/calibration_management/base_calibration_experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ def run(
self,
backend: Optional[Backend] = None,
analysis: Optional[Union[BaseAnalysis, None]] = "default",
timeout: Optional[float] = None,
**run_options,
) -> ExperimentData:
"""Run an experiment, perform analysis, and update any calibrations.
Expand All @@ -233,12 +234,16 @@ def run(
analysis. If None analysis will not be run. If ``"default"``
the experiments :meth:`analysis` instance will be used if
it contains one.
timeout: Time to wait for experiment jobs to finish running before
cancelling.
run_options: backend runtime options used for circuit execution.

Returns:
The experiment data object.
"""
experiment_data = super().run(backend, analysis, **run_options)
experiment_data = super().run(
backend=backend, analysis=analysis, timeout=timeout, **run_options
)

self._add_cal_metadata(experiment_data)

Expand Down
Loading