Improve handling of analysis callbacks#598
Closed
chriseclectic wants to merge 2 commits into
Closed
Conversation
chriseclectic
added
the
Changelog: Bugfix
chriseclectic
force-pushed
the
fix-callbacks
branch
from
8381d66 to
bf117dc
Compare
Collaborator
Author
|
Closing to merge with #599 since these two things depend on each other quite closely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reworks how analysis callbacks are run to use separate Futures for each callback.
This should fix issues #597, #592
Depends on #596
Details and comments
This fixes numerous issues with the previous implementation that added them all as a
done_callbackof job futures since each future can be monitored separately, and set to wait for any other prerequisite futures to first complete.