Small bugfix in interleaved RB data processing#580
Merged
Conversation
nkanazawa1989
approved these changes
Dec 14, 2021
Collaborator
nkanazawa1989
left a comment
nkanazawa1989
left a comment
There was a problem hiding this comment.
Good catch! This is because we have removed set analysis options however this logic is implicitly inherited from StandardRB class. Actually this happend because of current RB testing framework. Since we always regenerate reference files, we will never notice such important bug. @chriseclectic
nkanazawa1989
pushed a commit
to nkanazawa1989/qiskit-experiments
that referenced
this pull request
Jan 19, 2022
* Small bugfix in interleaved RB data processing * Test file data fix
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
* Small bugfix in interleaved RB data processing * Test file data fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments